Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: ensure test_status tests are self-contained #4133

Merged
merged 4 commits into from
May 16, 2023

Conversation

lengau
Copy link
Contributor

@lengau lengau commented May 11, 2023

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

Fixes #4132

@lengau lengau changed the title tests: ensure test_status are self-contained tests: ensure test_status tests are self-contained May 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented May 11, 2023

Codecov Report

Merging #4133 (75cf24b) into main (118d1ef) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 75cf24b differs from pull request most recent head ec5ec19. Consider uploading reports for the commit ec5ec19 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##             main    #4133   +/-   ##
=======================================
  Coverage   94.80%   94.80%           
=======================================
  Files         648      648           
  Lines       54280    54280           
=======================================
  Hits        51461    51461           
  Misses       2819     2819           
Impacted Files Coverage Δ
tests/unit/commands/test_status.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lengau lengau requested a review from sergiusens May 11, 2023 22:23
@sergiusens sergiusens merged commit df8f997 into canonical:main May 16, 2023
@lengau lengau deleted the status-tests branch May 16, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

status command unit tests are not self-contained
3 participants